Skip to content

French translation of documentation#67

Merged
SimplyCorey merged 1 commit intoSimpleSoftwareIO:developfrom
francisek:develop
Oct 17, 2016
Merged

French translation of documentation#67
SimplyCorey merged 1 commit intoSimpleSoftwareIO:developfrom
francisek:develop

Conversation

@francisek
Copy link
Copy Markdown
Contributor

#54 A less word to word translation than @Varpie did.

Comment thread docs/fr/README.md
<img src="{!!$message->embedData(QrCode::format('png')->generate('Embarquez-moi dans un courriel!'), 'QrCode.png', 'image/png')!!}">

<a id="docs-usage"></a>
## Usage
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

« Utilisation » is less word to word, and actually more correct.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

« Utilisation » and « Usage » could both be used. I prefer « Usage » in this case because it has a technical connotation.

Comment thread docs/fr/README.md
| Q | 25% de redondance. |
| H | 30% de redondance. |

>L'élévation du niveau de correction d'erreur se fait au détriment de la taille du QrCode et de la quantité de données qu'il peut stocker. Pour en savoir plus, consultez [error correction](http://en.wikipedia.org/wiki/QR_code#Error_correction) (en anglais).
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could have easily linked to the french page here (https://fr.wikipedia.org/wiki/Code_QR#Correction_d.27erreur)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but, the french page only provides values that are in the documentation.

Copy link
Copy Markdown

@Varpie Varpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good translation overall, I only disagree on a few points (check my comments on lines 77 and 156)

@SimplyCorey
Copy link
Copy Markdown
Member

@Varpie @francisek Thanks to both of you for making a translation. I see two different versions of the French translation. Which one should I merge in?

@Varpie
Copy link
Copy Markdown

Varpie commented Oct 15, 2016

@SimplyCorey I think @francisek's one is better, as he said mine is more word to word (also, I forgot to translate a few things, the list at the top for instance).

@SimplyCorey SimplyCorey added this to the 1.5.0 milestone Oct 17, 2016
@SimplyCorey SimplyCorey self-assigned this Oct 17, 2016
@SimplyCorey SimplyCorey merged commit 023242c into SimpleSoftwareIO:develop Oct 17, 2016
@SimplyCorey
Copy link
Copy Markdown
Member

@francisek @Varpie Thanks again guys.

@SimplyCorey SimplyCorey mentioned this pull request Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants